Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(sb): handle missing objects in Scenario Builder configuration #2038

Merged

Conversation

laurent-laporte-pro
Copy link
Contributor

Gestion des objets manquants dans le Scenario Builder

Description

Cette PR corrige une anomalie liée à la configuration du Scenario Builder. Elle permet de gérer les objets manquants suivants :

  • Renouvelables (v8.1),
  • Contraintes couplantes (v8.7),
  • Niveaux hydrauliques initiaux (v8.0) et finaux (v9.2),
  • Puissance de la génération de l'hydraulique (v9.1).

De plus, cette PR résout deux anomalies dans la commande de suppression d'une zone :

  1. Suppression des clusters renouvelables associés à la zone : Les clusters renouvelables sont maintenant correctement supprimés lorsqu'une zone est effacée.
  2. Suppression des objets du Scenario Builder associés à la zone : Les objets du Scenario Builder liés à une zone sont également supprimés.

Note : Cette PR ne traite pas de la gestion du Scenario Builder côté frontend.

Ce correctif permet d'utiliser l'API Swagger pour gérer la configuration du Scenario Builder. Veuillez noter que cette API est susceptible d'évoluer à l'avenir.

@laurent-laporte-pro laurent-laporte-pro self-assigned this May 27, 2024
@laurent-laporte-pro laurent-laporte-pro added bug Something isn't working hot labels May 27, 2024
@laurent-laporte-pro laurent-laporte-pro changed the base branch from dev to hotfix/v2.17.1 May 27, 2024 15:04
@laurent-laporte-pro laurent-laporte-pro changed the title bugfix(sb): handle missing objects in Scenation builder configuration bugfix(sb): handle missing objects in Scenario Builder configuration May 27, 2024
@laurent-laporte-pro laurent-laporte-pro force-pushed the bugfix/scenario-builder-missing-objects branch from ffad2c4 to a8003ac Compare May 28, 2024 13:35
hdinia
hdinia previously approved these changes May 29, 2024
Copy link
Member

@hdinia hdinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks solid overall. The update of the scenarios configuration after an area deletion is effectively implemented. I did notice that the deletion of clusters isn't correctly reflected (dont sure it was required tho).

@laurent-laporte-pro laurent-laporte-pro merged commit 500e865 into hotfix/v2.17.1 May 31, 2024
6 of 7 checks passed
@laurent-laporte-pro laurent-laporte-pro deleted the bugfix/scenario-builder-missing-objects branch May 31, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hot size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants