Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(hydro): avoid SonarCloud warning about unfilled todo #2017

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

laurent-laporte-pro
Copy link
Contributor

No description provided.

@laurent-laporte-pro laurent-laporte-pro added this to the v2.17.1 milestone Apr 25, 2024
@laurent-laporte-pro laurent-laporte-pro self-assigned this Apr 25, 2024
@skamril skamril requested review from MartinBelthle and removed request for skamril April 29, 2024 10:16
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the TODO but these change is ok for me

@MartinBelthle MartinBelthle merged commit ec66be3 into dev Apr 29, 2024
7 checks passed
@MartinBelthle MartinBelthle deleted the bugfix/ci-drop-todo-in-InputHydroIni branch April 29, 2024 12:59
@laurent-laporte-pro laurent-laporte-pro modified the milestones: v2.17.1, v2.17 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants