fix(commands): fix remove_cluster command and add unit tests for BC and area removal
#1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added aliases to the parameters of the Binding Constraint (BC) commands:
This way, we can have either snake_case or camelCase. I also added an integration test in the Thermals to test the deletion of a cluster that is referenced by a binding constraint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This Pull Request addresses a bug in the
remove_clustercommand and enhances our test coverage for the management of binding constraints and the removal of areas in studies of versions 7.2 and 8.7.Changes include:
Bug Fix in
remove_clustercommand: The command now correctly handles the removal of binding constraints matrices in version 8.7 when a thermal cluster is deleted.Unit Tests for Binding Constraints: Added new unit tests to verify the correct handling of binding constraints.
Unit Tests for Area Removal: Introduced new unit tests for the removal of areas in studies.