fix(launcher): adds default time limit submission #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvlecl
requested changes
Mar 12, 2024
skamril
reviewed
Mar 13, 2024
hdinia
force-pushed
the
bugfix/default-time-limit-submission
branch
6 times, most recently
from
89d9cee
to
cdebd07
Compare
laurent-laporte-pro
force-pushed
the
bugfix/default-time-limit-submission
branch
from
cdebd07
to
60cca11
Compare
laurent-laporte-pro
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://gopro-tickets.rte-france.com/browse/ANT-1271
Description:
This pull request fixes an issue in the
LauncherDialogcomponent where thetime_limitstate was not correctly set to a default value if the user modified fields other than thetime limititself before launching a simulation.Despite the UI correctly displaying the default time limit (converted from seconds to hours for user readability), the internal state
time_limitremained unset if the user did not explicitly change the time limit field.This could lead to unintended behavior when submitting the form.
Key Changes:
Initialization of
time_limitState:Ensured the time_limit state is initialized with DEFAULT_TIME_LIMIT in the component's initial state. This guarantees that the state correctly reflects the displayed default time limit even if the user does not interact with the time limit field.