Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clusters): add new endpoint for clusters duplication #1972

Conversation

MartinBelthle
Copy link
Contributor

@MartinBelthle MartinBelthle commented Mar 6, 2024

This branch only contains the back-end part.

One thing to note is that the code doesn't work for short term storages on variants (it doesn't update the matrix).
That bug will be fixed when this PR is merged : #1971

@laurent-laporte-pro laurent-laporte-pro changed the title feat(clusters): add new endpoint for duplication feat(clusters): add new endpoint for clusters duplication Mar 6, 2024
@laurent-laporte-pro laurent-laporte-pro force-pushed the fix/ANT-1161_add-matrix-support-for-clusters-duplication branch from 93b50b7 to 144e2d9 Compare March 7, 2024 15:53
@laurent-laporte-pro laurent-laporte-pro marked this pull request as draft March 8, 2024 08:56
@laurent-laporte-pro
Copy link
Contributor

@skamril @MartinBelthle There is issues with variant studies. I am working on it. Stay tuned!

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Mar 8, 2024
@laurent-laporte-pro laurent-laporte-pro marked this pull request as ready for review March 8, 2024 17:59
@laurent-laporte-pro laurent-laporte-pro force-pushed the fix/ANT-1161_add-matrix-support-for-clusters-duplication branch from 17bc134 to 2c29703 Compare March 8, 2024 17:59
@laurent-laporte-pro
Copy link
Contributor

By correcting the duplication of thermal and renewable clusters and short-term storage for the study variants, I also found an anomaly that I have corrected. This was an issue concerning the saving of short-term storage matrices: matrices were being saved directly in the variant's snapshot instead of generating commands.

@laurent-laporte-pro laurent-laporte-pro merged commit fcdb1c9 into dev Mar 9, 2024
7 checks passed
@laurent-laporte-pro laurent-laporte-pro deleted the fix/ANT-1161_add-matrix-support-for-clusters-duplication branch March 9, 2024 13:14
@laurent-laporte-pro
Copy link
Contributor

Related to #1971

laurent-laporte-pro pushed a commit that referenced this pull request Apr 11, 2024
@laurent-laporte-pro laurent-laporte-pro mentioned this pull request Apr 11, 2024
17 tasks
skamril pushed a commit that referenced this pull request Apr 19, 2024
skamril pushed a commit that referenced this pull request Apr 19, 2024
@skamril skamril mentioned this pull request Apr 19, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants