Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login submit issue #1660

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Fix login submit issue #1660

merged 4 commits into from
Jul 24, 2023

Conversation

skamril
Copy link
Member

@skamril skamril commented Jul 20, 2023

Impossible to click on the submit button after an error of login (the button remains disabled).

@commit-lint
Copy link

commit-lint bot commented Jul 20, 2023

Bug Fixes

  • ui-common: error with formState in Form (121d4e5)

Features

  • ui-common: add submitButtonIcon prop in Form (6b16e01)
  • ui-common: display submit error in Form (92d5a1e)
  • ui-login: update form (9631045)

Contributors

skamril

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@skamril skamril force-pushed the bugfix/login_submit branch 2 times, most recently from ebe179d to 96f7e74 Compare July 20, 2023 16:16
@skamril skamril added this to the v2.14.5 milestone Jul 20, 2023
@skamril skamril self-assigned this Jul 20, 2023
@skamril skamril modified the milestones: v2.14.5, v2.15 Jul 20, 2023
hdinia
hdinia previously approved these changes Jul 24, 2023
webapp/src/components/common/Form/index.tsx Outdated Show resolved Hide resolved
webapp/src/components/common/Form/index.tsx Show resolved Hide resolved
webapp/src/components/wrappers/LoginWrapper.tsx Outdated Show resolved Hide resolved
webapp/src/components/common/Form/index.tsx Show resolved Hide resolved
@skamril skamril merged commit 787fdc3 into dev Jul 24, 2023
7 of 8 checks passed
@skamril skamril deleted the bugfix/login_submit branch July 24, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants