No newline #1295
Merged
No newline #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jph00 , I'd like to reverse the direction on the "\n" fix.
Both Jupyter and IPython should not generate it in the future:
ipython/ipython#13941
jupyter/jupyter_client#931
I've also included a fix related to AttrDict. It receives nb as a plain dictionary when called from the jupyter pre_save_hook. Rather than play whack-a-mole, I modified clean_nb to work with a plain dict.
Let's hope this one concludes the series of PRs. :)
P.S. The readme change probably comes from the latest quarto.