Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "body_wrap" bits to APIRouter #612

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Adds "body_wrap" bits to APIRouter #612

merged 2 commits into from
Dec 21, 2024

Conversation

ohmeow
Copy link
Contributor

@ohmeow ohmeow commented Dec 21, 2024


name: Adds "body_wrap" bits to APIRouter
about: Added the ability to define a body_wrap function for APIRouter
title: Adds "body_wrap" bits to APIRouter


Related Issue
N/A

Proposed Changes
This PR brings APIRouter inline with FastHTML w/r/t having the ability to define a top-level body_wrap function to be across all related routes.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
N/A

Copy link

gitnotebooks bot commented Dec 21, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/612

@ohmeow ohmeow requested a review from jph00 December 21, 2024 03:18
Copy link
Contributor

@jph00 jph00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like you accidentally left a print() in there...

fasthtml/core.py Outdated
@@ -694,7 +695,9 @@ def __getattr__(self, name):

def to_app(self, app):
"Add routes to `app`"
for args in self.routes: app._add_route(*args)
for args in self.routes:
print(args)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(args)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah was hoping to get that fixed before you reviewed :). It should be good now.

@jph00 jph00 merged commit 065965a into main Dec 21, 2024
2 checks passed
@jph00 jph00 deleted the apirouter-refactor branch December 21, 2024 03:23
@jph00 jph00 added the enhancement New feature or request label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants