Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise highlightjs usage #602

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Optimise highlightjs usage #602

merged 1 commit into from
Dec 19, 2024

Conversation

curtis-allan
Copy link
Contributor


name: Highlightjs Fixes
about: Tiny changes to the js.py file
title: '[PR] '
labels: ''cleanup"
assignees: ''


Proposed Changes
Changed the default css selector in the Highlightjs function to work better with the HTMX onload functionality, so it doesn't try and re-highlight previous elements. Stops the console messages about already highlighted elements. Also just a small typo i saw.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have conducted tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

@curtis-allan curtis-allan added the cleanup minor code improvements that don't impact existing functionality label Dec 13, 2024
Copy link

gitnotebooks bot commented Dec 13, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/602

@curtis-allan curtis-allan requested a review from jph00 December 13, 2024 09:32
@jph00 jph00 merged commit 8302841 into main Dec 19, 2024
2 checks passed
@jph00 jph00 deleted the hljs_fix branch December 19, 2024 20:30
@jph00 jph00 changed the title Highlightjs Fixes Optimise highlightjs usage Dec 19, 2024
@jph00 jph00 added the enhancement New feature or request label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup minor code improvements that don't impact existing functionality enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants