Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN changes #599

Merged
merged 2 commits into from
Dec 12, 2024
Merged

CDN changes #599

merged 2 commits into from
Dec 12, 2024

Conversation

curtis-allan
Copy link
Contributor


name: CDN versioning & revisions
about: Use explicit version numbers where possible in the cdn links, along with additional minification where possible
title: '[PR] '
labels: "enhancement"


Proposed Changes
Updates to the CDN url's to use fixed version numbers on unpkg links where possible, and addition of a few .min extensions to jsdelivr links.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

@curtis-allan curtis-allan added the enhancement New feature or request label Dec 10, 2024
Copy link

gitnotebooks bot commented Dec 10, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/599

@curtis-allan curtis-allan requested a review from jph00 December 10, 2024 08:03
fasthtml/core.py Outdated Show resolved Hide resolved
@jph00
Copy link
Contributor

jph00 commented Dec 12, 2024

Thanks!

@jph00 jph00 merged commit f1cc346 into main Dec 12, 2024
2 checks passed
@jph00 jph00 deleted the cdn_changes branch December 12, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants