Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for passing route functions #511

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Allows for passing route functions #511

merged 1 commit into from
Oct 10, 2024

Conversation

Isaac-Flath
Copy link
Contributor


name: Pull Request
about: Propose changes to the codebase
title: '[PR] '
labels: ''
assignees: ''


Related Issue
Please link to the issue that this pull request addresses. If there isn't one, please create an issue first.

Proposed Changes
Currently you need to pass a string to HTMX to render in notebook. Ideally, you can just pass the function that was decorated. This allows you to do that by stringifying what is passed in. In the screenshot, note that I am passing the function that was decorated and NOT a string.

Screenshot 2024-10-10 at 3 30 42 PM

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

@Isaac-Flath Isaac-Flath added the enhancement New feature or request label Oct 10, 2024
@Isaac-Flath Isaac-Flath requested a review from jph00 October 10, 2024 19:32
Copy link

gitnotebooks bot commented Oct 10, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/511

@jph00 jph00 merged commit 6a2c0f0 into main Oct 10, 2024
2 checks passed
@jph00 jph00 deleted the HTMXnbRoutes branch October 10, 2024 21:10
@jph00
Copy link
Contributor

jph00 commented Oct 10, 2024

the str() isn't needed btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants