Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonus docs for Jupy+FH #493

Closed
wants to merge 3 commits into from
Closed

Bonus docs for Jupy+FH #493

wants to merge 3 commits into from

Conversation

pydanny
Copy link
Collaborator

@pydanny pydanny commented Oct 4, 2024


name: Pull Request
about: Propose changes to the codebase
title: '[PR] Bonus docs for Jupy+FH'
labels: 'documentation'
assignees: ''


Related Issue

#487 [DOCS] More features for the Jupyter+FastHTML demo

Proposed Changes

This change adds the following based on ticket #487 which is based on feedback from @jph00:

  • Show that we can refresh an HTMX handler by simply executing a different cell, and we don't have to restart the server or re-run HTMX()
  • If you modify the home page however, you do have to re-run HTMX() (but not the server).
  • Mention we can go to localhost:8000 in another tab to see a full screen view.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Copy link

gitnotebooks bot commented Oct 4, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/493

@pydanny pydanny force-pushed the doc-jupy-fh-bonus branch from 03f9e9a to 24dbaee Compare October 4, 2024 16:26
@pydanny pydanny marked this pull request as ready for review October 4, 2024 16:27
@pydanny pydanny self-assigned this Oct 4, 2024
@pydanny pydanny requested review from audreyfeldroy and jph00 October 4, 2024 16:28
@jph00
Copy link
Contributor

jph00 commented Oct 4, 2024 via email

Copy link

@liamlio liamlio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small typo on line 16 in the tutorial notebook:
To wrote FastHTML --> To write FastHTML

Just thought I'd add this comment here since there was an open PR for this notebook anyway! Thanks for the tutorial :)

@pydanny pydanny closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants