Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Make sure only the selected radio button in a radio group is checked during form_fill #424

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

rbavery
Copy link
Contributor

@rbavery rbavery commented Sep 13, 2024


name: Radio Group fill_form fix
about: Make sure only the selected radio button in a radio group is checked during form_fill
title: '[PR] '
labels: ''
assignees: ''


Related Issue
#423

Proposed Changes
This handles radio type inputs separately to check if the value key of the radio input is equal to the val of the obj that is filling in the radio group

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
See the issue: #423

this is the working mre where refreshing the page keeps the radio selection on True
working_mre

Copy link

gitnotebooks bot commented Sep 13, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/424

@rbavery rbavery changed the title {Fix] Make sure only the selected radio button in a radio group is checked during form_fill [Fix] Make sure only the selected radio button in a radio group is checked during form_fill Sep 13, 2024
@jph00 jph00 added the bug Something isn't working label Sep 14, 2024
@jph00 jph00 merged commit 5ef78c0 into AnswerDotAI:main Sep 14, 2024
1 check failed
@rbavery rbavery deleted the rbavery/fill_form_radio_group branch September 14, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants