Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to change default static media directory #373

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

coreman14
Copy link
Contributor

Related Issue
#355

Proposed Changes
Added a argument to fast_app that allows the user to change the default static media folder being the root directory. Updated the documentation to reflect this change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Copy link

gitnotebooks bot commented Aug 27, 2024

Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/373

@jph00
Copy link
Contributor

jph00 commented Aug 29, 2024

Oh good idea!

@jph00 jph00 merged commit 1807dca into AnswerDotAI:main Aug 29, 2024
1 check passed
@jph00 jph00 added the enhancement New feature or request label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants