Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Starlette's session in an AttrDict #213

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

jbellis
Copy link
Contributor

@jbellis jbellis commented Aug 6, 2024

Testing status:

fasthtml:

  • nbdev_test passes except oauth, which also fails without this patch (No such file or directory: '../examples/gh_secret.env')

manually testing fasthtml-examples using sessions:

  • todos2: works, including when modified to use attribute syntax
  • image_app_session_credits: skipped (requires giving Replicate my billing info)
  • data_spot_check: works
  • 03_pictionary: No such file or directory: 'multiplayer.css' (same error without this patch)

Copy link

gitnotebooks bot commented Aug 6, 2024

Found 1 changed notebook. Review the changes at https://gitnotebooks.com/AnswerDotAI/fasthtml/pull/213

@jbellis
Copy link
Contributor Author

jbellis commented Aug 7, 2024

Also confirmed that home and about work, although neither appears to use sessions.

@jph00
Copy link
Contributor

jph00 commented Aug 7, 2024

Thank you! PS: tag me for review, or at-mention me, so I don't miss PRs in the future.

@jph00 jph00 added the enhancement New feature or request label Aug 7, 2024
@jph00 jph00 merged commit b73f98d into AnswerDotAI:main Aug 7, 2024
@jph00
Copy link
Contributor

jph00 commented Aug 7, 2024

Oh and also - thank you for the careful testing :D

@jbellis
Copy link
Contributor Author

jbellis commented Aug 7, 2024

Thanks, and will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants