Add support for FastGyroidInfill #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I think this should probably be supported with future (limited) macro expansion(as worked on in #30 ). I'm weary of integrating highly specialized systems like this in the core estimator. Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the klipper-FastGyroidInfill thingy, by allowing a
gyroid_square_corner_velocityto be set in the config, which will be set as the SQV whenever a_USE_INFILL_SQVcommand is hit, with the normal SCV being restored upon hitting a_USE_NORMAL_SQVcommand.Currently, this requires a config file to set
gyroid_square_corner_velocity, although it could probably be easily obtained by checking the saved variables from Moonraker for theinfill_sqvvariable.