Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Parser Classes Public #111

Closed
jbienzms opened this issue May 5, 2022 · 1 comment
Closed

Make Parser Classes Public #111

jbienzms opened this issue May 5, 2022 · 1 comment
Milestone

Comments

@jbienzms
Copy link

jbienzms commented May 5, 2022

New Feature Proposal

Description

I would like to parsing related types made public. Most of them can be found in the Parser folder.

Background

I'm working on a sample application that can load A-Frame content. The attribute syntax for A-Frame Multi-Property components conforms to CSS guidelines. Therefore, I'd like to use AngleSharp classes like IdentParser to parse the values stored in these attributes. Unfortunately, since the types in this folder do not have an explicit access modifier, they're defaulting to Internal and are not public.

Specification

I do not believe that making these parser classes public would have an impact on any the spec.

@FlorianRappl FlorianRappl added this to the v0.17 milestone May 31, 2022
FlorianRappl added a commit that referenced this issue Jun 2, 2022
@FlorianRappl
Copy link
Contributor

Landed in devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants