Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement different default conf-paths #25

Closed
4 of 5 tasks
Andrwe opened this issue Mar 13, 2022 · 1 comment · Fixed by #26
Closed
4 of 5 tasks

implement different default conf-paths #25

Andrwe opened this issue Mar 13, 2022 · 1 comment · Fixed by #26
Assignees
@Andrwe
Labels
enhancement
Milestone
version 0.4

Comments

@Andrwe
Copy link
Owner

Andrwe commented Mar 13, 2022 •
edited
Loading

Currently the configuration directory is hard-coded to /etc/conf.d/privoxy-blacklist which is a good path to store the configuration on OpenWRT as that's the only persistent directory.

As that is a bad default for other OS this should be changed in the following manner:

  • allow specifying the path via argument
  • set on Darwin to /usr/local/etc/privoxy-blocklist.conf (based on change by @eudemonics
    • not using privoxy config directory to prevent breaking privoxy setups
  • use old default when it exists (to reduce breaking setups)
  • use /etc/config/privoxy-blocklist.conf on TurrisOS
  • use /etc/privoxy-blocklist.conf as default
@Andrwe Andrwe self-assigned this Mar 13, 2022
Andrwe added a commit that referenced this issue Mar 13, 2022
@Andrwe
implement #25 & several improvements
1bce4a1 
* implement option `-c` to specify script config file
* implement OS specific defaults for script config file
* increase version to 0.4
* move code to dedicated functions to reduce requirements for different calls
* add info output function
* add Dockerfile to run test suite on Ubuntu
* improve tests/run.sh to allow running on different OS container
* add test for dependency check
* add test for custom script config path

Signed-off-by: Andrwe Lord Weber <github@andrwe.org>
@Andrwe
Copy link
Owner Author

Andrwe commented Mar 13, 2022

The implementation on TurrisOS was moved to LuCi based configuration and requires more changes to support it.
Thus dropping for now.

@Andrwe Andrwe added this to the version 0.4 milestone Mar 13, 2022
@Andrwe Andrwe mentioned this issue Mar 13, 2022
Merged
Andrwe added a commit that referenced this issue Mar 13, 2022
@Andrwe
implement #25 & several improvements (#26)
80ce60f 
* implement option `-c` to specify script config file
* implement OS specific defaults for script config file
* increase version to 0.4
* move code to dedicated functions to reduce requirements for different calls
* add info output function
* add Dockerfile to run test suite on Ubuntu
* improve tests/run.sh to allow running on different OS container
* add test for dependency check
* add test for custom script config path

Signed-off-by: Andrwe Lord Weber <github@andrwe.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Andrwe Andrwe

Labels
enhancement
Projects
None yet
Milestone
version 0.4
Development

Successfully merging a pull request may close this issue.

implement #25 & several improvements Andrwe/privoxy-blocklist
1 participant
@Andrwe