Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

[Bug]: Editor color scheme issues #1051

Closed
2 tasks done
Rafael2616 opened this issue Jun 19, 2023 · 3 comments
Closed
2 tasks done

[Bug]: Editor color scheme issues #1051

Rafael2616 opened this issue Jun 19, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Rafael2616
Copy link
Contributor

Rafael2616 commented Jun 19, 2023 •
edited
Loading

What happened?

Writing in the Android IDE, I noticed some color inconsistencies when I do certain things in my code, here are the main mistakes I noticed

1- Referencing an activity in a context turns its color white as you can see in the images below

Screenshot_20230619-104012
Screenshot_20230619-104005

2 - Put variable and private variables as parameter of classes, data classes makes that contents of the parentheses blue, if i remove the leading parenthesis it seems to go back to normal colors but that would not compile

Screenshot_20230619-103830

Screenshot_20230619-103841

3- Annotations color should be yellow in my opinion not only because it matches Android Studio, but because in certain cases it would differ from the color of other elements that are already blue too as in this example where the class name is already blue and the annotation parameter which is also blue this would make it more readable

Screenshot_20230619-103855

for color comparison
Screenshot_20230619-002449

I think these are the main points

What's the expected behavior?

Colors do not suffer from these inconsistencies when writing code and make the code more beautiful visualization

What version of AndroidIDE you're using?

v2.4.0 (debug builds)

Relevant log output

No response

Duplicate issues

  • This issue has not been reported yet.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Rafael2616 Rafael2616 added the bug Something isn't working label Jun 19, 2023
@itsaky itsaky closed this as completed in b9d84e4 Jul 16, 2023
ThatMG393 added a commit to ThatMG393/AndroidIDE that referenced this issue Jul 16, 2023
@ThatMG393 @itsaky
sync dev -> useful-mos (#1)
acb4f94 
* fix: parse OpenedFilesCache manually to avoid ClassCastException in release builds (fixes AndroidIDEOfficial#1102)

* chore(workflow): maven central credentials not provided to 'publish' job

* chore(workflow): run 'publish_snapshots' job on branches other than 'main'

* chore: fix apk file path in Nyx config

* build: fix project description missing in modules that are published

* fix: close tree sitter language instance when editor language is destroyed

* build: require project description for modules that are published to maven central

* docs: update links in README

* docs: update README

* fix(editor): update syntax highlights for Java and Kotlin (fixes AndroidIDEOfficial#1051)

* chore: update version numbers in issue templates

* fix: simplify logic for determining forward/backward transition in main activity

* fix(editor): invalid syntax highlights for annotations in Java

* fix(editor): fall back to default color scheme if custom scheme doesn't support a file type

* Update gradlew

---------

Co-authored-by: Akash Yadav <itsaky01@gmail.com>
@Rafael2616
Copy link
Contributor Author

It got much better for annotations an params, but the error 1 quoted still doesn't look so good
Screenshot_20230716-080358

@itsaky
Copy link
Member

itsaky commented Jul 16, 2023

I'll have to modify the grammar for this which could take some time. This is because that statement can have a qualified reference as well. For example :

this@Activity.field.method()

@Rafael2616
Copy link
Contributor Author

Ok, I got it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itsaky @Rafael2616