Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable codecov if PR head and base are different or CODECOV_TOKEN not set #174

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

AndreasLrx
Copy link
Owner

Description

The CI should not fail anymore when running PR from forks toward this repository, the codecov action will be skipped.
It would have been better to always run but doesn't seem possible for security reason (codecov/codecov-action#29)

It should still work on fork if they set their own CODECOV_TOKEN secret.

Close #169

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

[optional] Minor fixes

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a CI update
  • I need help with writing tests

@AndreasLrx AndreasLrx added bug Something isn't working ci Github workflows labels Oct 18, 2024
@AndreasLrx AndreasLrx self-assigned this Oct 18, 2024
@AndreasLrx AndreasLrx force-pushed the fix/169-codecov-from-fork branch 2 times, most recently from 0943d8b to cc9d4fe Compare October 18, 2024 10:21
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (2706640) to head (cc9d4fe).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files          64       64           
  Lines        1129     1129           
  Branches      352      352           
=======================================
  Hits          925      925           
  Misses        144      144           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreasLrx AndreasLrx force-pushed the fix/169-codecov-from-fork branch from cc9d4fe to 5a59f77 Compare October 18, 2024 10:26
@AndreasLrx AndreasLrx merged commit f882572 into main Oct 18, 2024
1 check passed
@AndreasLrx AndreasLrx deleted the fix/169-codecov-from-fork branch October 18, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Github workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CodeCov CI fails when running from a fork
2 participants