added positionOffset which allows a vertical offset for the flushbar #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching to padding versus viewInsets
|
I updated the position calculation to use padding versus viewInsetsBottom. This seems to resolve issues with the iPhone X and the safe area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds positionOffset which allows a vertical offset for the flushbar and addresses the open issue:
#98
The actual stacking logic is implemented in the application code, but the offset is needed to utilize the logic. Overlay is unchanged, so multiple active flushbar instances can stack overlays. Unsure how/if that needs to be addressed in this PR.