Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly update Entry's location to match World's updated state. #217

Merged
merged 4 commits into from
Apr 22, 2023

Conversation

Anders429
Copy link
Owner

This fixes #216.

@Anders429 Anders429 added C - Bug Category: Something is not functioning as expected. C - Crash Category: Unexpected crashing caused by this library. C - Unsound Category: Undefined behavior. P - Critical Priority: Must be fixed immediately. A - Storage Area: Storage inside a World. labels Apr 22, 2023
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #217 (b62606a) into dev (6589f5d) will increase coverage by 0.00%.
The diff coverage is 96.29%.

@@           Coverage Diff           @@
##              dev     #217   +/-   ##
=======================================
  Coverage   96.94%   96.95%           
=======================================
  Files          85       85           
  Lines       14017    14040   +23     
=======================================
+ Hits        13589    13612   +23     
  Misses        428      428           
Impacted Files Coverage Δ
src/world/mod.rs 99.85% <90.90%> (-0.05%) ⬇️
src/world/entry.rs 96.85% <100.00%> (+0.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Anders429
Copy link
Owner Author

The patch coverage thing is a false flag. It's counting the macro call as a missed statement. In reality, this only adds covered lines of code.

@Anders429 Anders429 merged commit f5ea542 into dev Apr 22, 2023
@Anders429 Anders429 deleted the entry branch April 22, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A - Storage Area: Storage inside a World. C - Bug Category: Something is not functioning as expected. C - Crash Category: Unexpected crashing caused by this library. C - Unsound Category: Undefined behavior. P - Critical Priority: Must be fixed immediately.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant