-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve generic parameter names #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anders429
added
C - Documentation
Category: Improvements or additions to documentation.
C - Code Quality
Category: Addressing quality and cleanup of existing code.
P - Low
Priority: Not particularly urgent.
C - Usability
Category: How easy it is for users to use the library.
labels
Apr 18, 2023
Codecov Report
@@ Coverage Diff @@
## dev #213 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 85 85
Lines 14000 14017 +17
=======================================
+ Hits 13572 13589 +17
Misses 428 428
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C - Code Quality
Category: Addressing quality and cleanup of existing code.
C - Documentation
Category: Improvements or additions to documentation.
C - Usability
Category: How easy it is for users to use the library.
P - Low
Priority: Not particularly urgent.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces cryptic letters (
C
,R
,S
, etc.) with full names for public-facing generic parameters. Closes #171.The only one I didn't touch was
System::run()
andParSystem::run()
. I would like for those to look as unintimidating as possible to external users, and the effort to make it so is being tracked in #188.