Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Reshape traits. #211

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Merge Reshape traits. #211

merged 4 commits into from
Apr 17, 2023

Conversation

Anders429
Copy link
Owner

Similar to #210, this simply replaces the various Reshape traits with a generic Reshape trait.

This, like Get, turned out to be pretty easy because it's a fundamental operation that was defined nearly exactly the same each time. It turns out reshaping is not done as much as extraction through Get, but I anticipate it could be used more in the future as more features are built into the library.

@Anders429 Anders429 added C - Code Quality Category: Addressing quality and cleanup of existing code. P - Low Priority: Not particularly urgent. labels Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #211 (ead3472) into dev (567b985) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #211      +/-   ##
==========================================
- Coverage   96.94%   96.94%   -0.01%     
==========================================
  Files          86       85       -1     
  Lines       14009    14000       -9     
==========================================
- Hits        13581    13572       -9     
  Misses        428      428              
Impacted Files Coverage Δ
src/hlist/mod.rs 98.18% <ø> (ø)
src/query/result/iter.rs 98.66% <ø> (ø)
src/query/result/par_iter.rs 83.14% <ø> (ø)
src/registry/contains/par_views/sealed.rs 100.00% <ø> (ø)
src/world/entry.rs 96.02% <ø> (ø)
src/archetype/mod.rs 98.05% <100.00%> (-0.02%) ⬇️
src/hlist/reshape.rs 100.00% <100.00%> (ø)
src/query/entries.rs 100.00% <100.00%> (ø)
src/registry/contains/views/sealed.rs 97.85% <100.00%> (-0.15%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Anders429 Anders429 merged commit e3688fa into dev Apr 17, 2023
@Anders429 Anders429 deleted the reshape branch April 17, 2023 18:51
@Anders429 Anders429 added this to the 0.9.0 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - Code Quality Category: Addressing quality and cleanup of existing code. P - Low Priority: Not particularly urgent.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant