fix: replace useEffect with useLayoutEffect for React 17 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 37eed99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
reviewed
Feb 9, 2021
There was a problem hiding this comment.
Could you also move usage of the useWindowResizeListener to this branch of the code?
react-textarea-autosize/src/index.tsx
Line 93 in 9ba98b9
It will avoid React warnings about using useLayoutEffect during SSR.
`useEffect` cleanup runs since React 17 asynchronously thats why it needs to be changed Fixes Andarist#259
|
@Andarist like that? |
Andarist
reviewed
Feb 10, 2021
|
Thanks! |
Merged
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useEffectcleanup runs since React 17 asynchronously thats why it needs to be changedWe deployed this change to a web application with quite a lot of users and could verify that the
Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.errors were gone.Fixes #259
cc @Andarist