fix swift lint issue

AnbalaganD · Mar 12, 2024 · 1b25ad4 · 1b25ad4
1 parent ddb4723
commit 1b25ad4
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 17 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -24,5 +24,6 @@ jobs:
     steps:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - uses: actions/checkout@v3
+
       - name: GitHub Action for SwiftLint
         uses: norio-nomura/action-swiftlint@3.2.1
diff --git a/LibraryManagement/Modules/Book/AddBookController.swift b/LibraryManagement/Modules/Book/AddBookController.swift
@@ -50,14 +50,14 @@ final class AddBookController: UIViewController {
     }
 
     private func setupData(_ book: Book?) {
-        if let b = book {
-            bookNameTextField.text = b.name
-            authorTextFeild.text = b.author
-            stockTextFeild.text = "\(b.stock)"
-            descriptionTextView.text = b.description
-
-            guard let url = URL(string: b.coverImage), let imageData = try? Data(contentsOf: url) else {
-                coverImageView.image = UIImage(named: b.coverImage)
+        if let book {
+            bookNameTextField.text = book.name
+            authorTextFeild.text = book.author
+            stockTextFeild.text = "\(book.stock)"
+            descriptionTextView.text = book.description
+
+            guard let url = URL(string: book.coverImage), let imageData = try? Data(contentsOf: url) else {
+                coverImageView.image = UIImage(named: book.coverImage)
                 return
             }
             coverImageView.image = UIImage(data: imageData)
@@ -217,6 +217,7 @@ extension AddBookController: UIImagePickerControllerDelegate, UINavigationContro
 }
 
 extension AddBookController {
+    // swiftlint:disable:next function_body_length
     private func setupView() {
         view.backgroundColor = .systemBackground
 

diff --git a/LibraryManagement/Modules/Book/BookListController.swift b/LibraryManagement/Modules/Book/BookListController.swift
@@ -25,10 +25,6 @@ final class BookListController: UIViewController {
         bookListTableView.reloadData()
     }
 
-    override func viewWillDisappear(_ animated: Bool) {
-        super.viewWillDisappear(animated)
-    }
-
     override func viewWillAppear(_ animated: Bool) {
         super.viewWillAppear(animated)
         DispatchQueue.main.asyncAfter(deadline: .now() + 0.05) {
@@ -266,7 +262,7 @@ extension BookListController: UITableViewDelegate, UITableViewDataSource {
                 .init(
                     style: .normal,
                     title: "Edit"
-                ) {[weak self] action, view, handler in
+                ) {[weak self] _, _, handler in
                     if let book = self?.bookList[indexPath.row] {
                         self?.editBook(book: book)
                         handler(true)
@@ -275,7 +271,7 @@ extension BookListController: UITableViewDelegate, UITableViewDataSource {
                 .init(
                     style: .destructive,
                     title: "Delete"
-                ) {[weak self] action, view, handler in
+                ) {[weak self] _, _, handler in
                     self?.confirmDelete(indexPath: indexPath)
                     handler(true)
                 }
@@ -291,16 +287,16 @@ extension BookListController: UITableViewDelegate, UITableViewDataSource {
         UIContextMenuConfiguration(
             identifier: nil,
             previewProvider: nil
-        ) { item in
+        ) { _ in
             UIMenu(
                 title: "Action",
                 children: [
-                    UIAction(title: "Edit") {[weak self] action in
+                    UIAction(title: "Edit") {[weak self] _ in
                         if let book = self?.bookList[indexPath.row] {
                             self?.editBook(book: book)
                         }
                     },
-                    UIAction(title: "Delete", attributes: .destructive) {[weak self] action in
+                    UIAction(title: "Delete", attributes: .destructive) {[weak self] _ in
                         if self?.bookList[indexPath.row] != nil {
                             self?.confirmDelete(indexPath: indexPath)
                         }