Update the URI for Porkbun's API #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new URI is live now; the old one will stop accepting API calls on December 1st. New URI is documented at https://porkbun.com/api/json/v3/documentation
Added notes for others who may want to run the tests. Also filtering out any 503 responses from the recordings since they aren't important.
|
Excellent contribution, with a good usage of vcrpy, and I appreciate the inline comments to help maintaining the tests and cassettes. Thanks a lot. I rebased your PR in #2129 with the recent changes I did who removes in particular issues associated to Python 3.8. All tests I green, so this LGTM! |
|
@adferrand Thanks! Happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new URI is live now; the old one will stop accepting API calls on December 1st, according to this email I got from them:
Their documentation already references the new URI and confirms that the old one is deprecated: https://porkbun.com/api/json/v3/documentation
I confirmed the new URI seems to work here by running a few manual commands (like
lexicon porkbun list <mydomain> A), and was also able to use the updated porkbun.py to generate new Let's Encrypt certs via dehydrated in a live TKL Core VM.As I was updating the Porkbun test cassettes, I ran into Porkbun's rate limits, so ended up adding retries when we get a 503 response, following a pattern I saw used in the DNSMadeEasy provider. This lets the tests pass, but the 503's clutter up the recorded data, so I also filtered those responses out in
_filter_response.Please take a look and let me know if there's anything else I should do here. Thanks!