Add support for Timeweb provider #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W239 seems to be a false positive here, since it relates to a formatted multiline description.
The implementation has been done according to the [guidelines][1], all tests seem to be working, except for three cases: - A type subdomain record creation (no direct support from the provider) - CNAME type subdomain record creation (same reason) - TTL modification (the provider uses TTL=600 for all records) [1]: https://dns-lexicon.readthedocs.io/en/latest/developer_guide.html
From the previous steps one could imply that you are already in `lexicon` directory, so no need to have it in the path.
|
This LGTM to me. Thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Lexicon as a part of Letsencrypt certbot, and I needed support for my hosting provider, Timeweb. Thanks for the contributing guidelines, they are pretty straightforward -- hopefully all the requirements have been met.
Had to skip a couple of tests since Timeweb's DNS functionality is quite crippled (more info in commit description). All other tests seem to pass.