Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Wedos WAPI #1675

Merged
merged 10 commits into from
Aug 7, 2023
Merged

Support for Wedos WAPI #1675

merged 10 commits into from
Aug 7, 2023

Conversation

vojtakaniok
Copy link
Contributor

@vojtakaniok vojtakaniok commented Aug 6, 2023

Hi @AnalogJ
I created Wedos WAPI provider.
Can you please check my implementation?
Documentation for the WAPI:
https://kb.wedos.com/en/kategorie/wapi-api-interface/

@vojtakaniok vojtakaniok marked this pull request as draft August 6, 2023 09:01
@vojtakaniok vojtakaniok marked this pull request as ready for review August 6, 2023 14:03
Copy link
Collaborator

@adferrand adferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, very good work ! I just have two comments, including a potential better error management for validations failures.

lexicon/providers/wedos.py Outdated Show resolved Hide resolved
lexicon/tests/providers/test_wedos.py Outdated Show resolved Hide resolved
@vojtakaniok vojtakaniok requested a review from adferrand August 7, 2023 14:42
Copy link
Collaborator

@adferrand adferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me ! Thanks a lot !

@adferrand adferrand merged commit beb2354 into AnalogJ:master Aug 7, 2023
@vojtakaniok vojtakaniok deleted the wedos branch August 7, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants