Menuitems on products #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Guldborg
force-pushed
the
feature/menuitems-on-products
branch
from
2ac946f to
75f2d0b
Compare
A-Guldborg
commented
Feb 15, 2024
There was a problem hiding this comment.
@TTA777 I believe this answers the questions you had on Tuesday. Let me know if I forgot/missed something, or if you have further questions :)
(I removed ToString on our domain models and reverted to using Enumerable instead of ObservableCollection, as it was only required to use the StateHasChanged but not the ObservableCollection)
Also - seems there were just a few lines difference between my non-working local API specs and the ones that I now obtained from the dev swagger, so I assume I might've tested it against a wrong or outdated backend branch. The API specs now match the current dev server.
TTA777
previously requested changes
Feb 15, 2024
duckth
force-pushed
the
feature/menuitems-on-products
branch
from
1abdca5 to
29413d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds menu items to products (Half of #23).
The EditForm on the product manager now has a ComboBox with both textual input (searching) and multiselection in a dropdown to avoid taking up too much space:
This PR also addresses breaking changes in the products API from AnalogIO/analog-core#253 which must be merged first.
This PR also includes minor bugfixes: