New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MobilePay API to latest version #114

Merged

jonasanker merged 8 commits into develop from feature/jonas/update-mpapi

May 9, 2023

Member

jonasanker commented Nov 26, 2022

Closes #113

jonasanker self-assigned this

codecov-commenter commented Nov 26, 2022 •

edited

Loading

Codecov Report

Merging #114 (eabb6cd) into develop (2fa3f53) will decrease coverage by 0.93%.
The diff coverage is 1.19%.

@@             Coverage Diff             @@
##           develop     #114      +/-   ##
===========================================
- Coverage    16.27%   15.34%   -0.93%     
===========================================
  Files          156      156              
  Lines         7215     7658     +443     
  Branches       439      507      +68     
===========================================
+ Hits          1174     1175       +1     
- Misses        6006     6448     +442     
  Partials        35       35

Impacted Files	Coverage Δ
...eeCard.Common/Configuration/MobilePaySettingsV2.cs	`100.00% <ø> (ø)`
...d/CoffeeCard.Library/Services/v2/WebhookService.cs	`0.00% <0.00%> (ø)`
...ard.MobilePay/Generated/PaymentsApi/PaymentsApi.cs	`0.00% <ø> (ø)`
...ard.MobilePay/Generated/WebhooksApi/WebhooksApi.cs	`0.00% <0.00%> (ø)`
...d.MobilePay/Service/v2/MobilePayPaymentsService.cs	`0.00% <0.00%> (ø)`
...d.MobilePay/Service/v2/MobilePayWebhooksService.cs	`0.00% <0.00%> (ø)`
...eCard.WebApi/Controllers/v2/MobilePayController.cs	`0.00% <0.00%> (ø)`
...lePay/Utils/MobilePayServiceCollectionExtension.cs	`57.14% <33.33%> (+10.47%)`	⬆️
coffeecard/CoffeeCard.WebApi/Startup.cs	`85.71% <100.00%> (+0.08%)`	⬆️

jonasanker requested a review from a team

November 26, 2022 22:31

jonasanker added the mobilepay label

sonarqubecloud bot commented Nov 27, 2022

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

2.4% Coverage
0.0% Duplication

TTA777 approved these changes

View reviewed changes

Member

TTA777 left a comment

lgtm

TTA777 previously requested changes

View reviewed changes

Member

TTA777 left a comment

One minor comment

coffeecard/CoffeeCard.MobilePay/Service/v2/MobilePayPaymentsService.cs Show resolved Hide resolved

jonasanker force-pushed the feature/jonas/update-mpapi branch from cb53f53 to 41298b8 Compare

February 12, 2023 09:28

sonarqubecloud bot commented Feb 12, 2023

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

2.4% Coverage
0.0% Duplication

jonasanker added 8 commits

May 9, 2023 18:58


          Update MobilePay API to latest version

f8916f2


          Update Webhook service

3aa2b6d


          Rewording

645db54


          Read Mp Signature Key from cache

292558c


          Register Memory Cache

dd8e64a


          Move cache to WebhookService

aa8eaf4


          Remove ClientId as authentication

6e6048c


          Remove ClientId from appsettings

eabb6cd

jonasanker force-pushed the feature/jonas/update-mpapi branch from 41298b8 to eabb6cd Compare

May 9, 2023 16:58

jonasanker enabled auto-merge (squash)

May 9, 2023 17:00

sonarqubecloud bot commented May 9, 2023

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

2.4% Coverage
0.0% Duplication

duckth approved these changes

View reviewed changes

jonasanker requested review from TTA777 and removed request for TTA777

May 9, 2023 17:37

jonasanker dismissed TTA777’s stale review

May 9, 2023 17:38

Approved by Andreas

jonasanker merged commit 7e92d8e into develop

jonasanker deleted the feature/jonas/update-mpapi branch

May 9, 2023 17:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels