Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.76 #7
V1.76 #7
Changes from all commits
2fa7f89
5f76ccc
6f10f90
c6abc00
9c22bae
bacfebb
1b51f99
21e4b8e
7b37911
c312648
9fcf911
0366d12
e86e0ed
ba955a1
20a8e54
b48ba42
dfe647e
6fde3c5
cd38c5f
4b836ff
104eecc
8968ff4
aadc30d
6e130de
896ba46
153ca18
9ff72af
1481b8e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libiconv
is required onlinux
but here is onlyosx
. Hmm https://github.com/rust-lang/rust/blob/master/INSTALL.md#dependenciesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl
is needed onunix
, see https://github.com/rust-lang/rust/blob/master/INSTALL.md#dependenciesShould we add it to
host
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build is installing but not actually building, so we are fine here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all
.dylib
have the selector# [osx]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could, but that won't change the end result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a known defect of
s390x
only like$RPATH/ld64.so.1
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is a c compiler necessary for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To run forge_test.sh, a backend compiler is required.
Usually this is brought in by the activation feedstock, but here we are one step early, so we need to include it in test/requires.