Add dep on libgcc mutex package #30
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarahan
reviewed
Jul 1, 2019
free.py
Outdated
| @@ -204,6 +204,9 @@ def _patch_repodata(repodata, subdir): | |||
| xtractd = record["track_features"] = _extract_track_feature(record, feat) | |||
| instructions["packages"][fn]["track_features"] = xtractd | |||
|
|
|||
| if any(dep == 'libgcc' for dep in record['depends']): | |||
There was a problem hiding this comment.
Could be simpler - just add it only to the libgcc package(s) themselves, not to all the things that use libgcc
There was a problem hiding this comment.
But wait - I'm not sure this file is even used for hotfixing free? I think there's code in continuumio/anaconda that does it.
There was a problem hiding this comment.
I couldn't find any script that does hotfixing (though it does say in the README that it does hotfixing) in that repo. Also couldn't find anything in confluence about it
msarahan
reviewed
Jul 1, 2019
soapy1
force-pushed
the
libgcc-mutex
branch
2 times, most recently
from
d5c1b89 to
e04924a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conda/conda#8844 (comment)