Updates for ArmPL variant builds #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katietz
approved these changes
Oct 14, 2021
katietz
approved these changes
Oct 14, 2021
varlackc
reviewed
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several updates to build
numpywith ArmPL:aarch_site.cfgand the code ininstall_base.shthat copied it into$PREFIX. Thesite.cfgshould actually be provided by the BLAS package (in this case,armpl). Appropriate changes for that have been made inarmpl-feedstock.recipe/patches/0007-armpl-build.patchincorporates all the configurations necessary to buildnumpywith ArmPL, as described in this guide: https://gitlab.com/arm-hpc/packages/-/wikis/packages/numpy#build-configuration-1armplas a host dependency with a selector forblas_impl == armpl.I have validated these updates by building
armplvariants ofnumpyandnumpy-base- see here:https://anaconda.org/aarch64-staging/numpy/files?channel=armpl_build_20211014
https://anaconda.org/aarch64-staging/numpy-base/files?channel=armpl_build_20211014