Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13.0 #14

Merged
merged 12 commits into from
Oct 30, 2024
Merged

v1.13.0 #14

merged 12 commits into from
Oct 30, 2024

Conversation

ahuang11
Copy link

@ahuang11 ahuang11 commented Oct 1, 2024

geoviews 1.13.0

Destination channel: defaults

Links
Upstream repository
Upstream changelog/diff
Explanation of changes:
https://github.com/conda-forge/geoviews-feedstock/pull/41/files

@ahuang11 ahuang11 requested a review from maximlt October 1, 2024 18:57
@ahuang11 ahuang11 requested a review from philippjfr as a code owner October 1, 2024 18:57
@ahuang11
Copy link
Author

ahuang11 commented Oct 1, 2024

Supersedes #13 now that I have permission to make branches directly in this repo.

@anaconda-pkg-build
Copy link

Linter check found the following problems: ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_fae_etlasm/clone` failed. (See above for error) The following problems have been found:

===== ERRORS =====

  • clone/recipe/meta.yaml:42: remove_python_pinning: On arch specific packages, python deps should not be constrained.
  • clone/recipe/meta.yaml:54: remove_python_pinning: On arch specific packages, python deps should not be constrained.
    ===== Final Report: =====
    2 Errors and 0 Warnings were found

@ahuang11
Copy link
Author

ahuang11 commented Oct 1, 2024

Not sure why the tests are failing

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@maximlt
Copy link

maximlt commented Oct 17, 2024

@ahuang11 do you think this is unblocked now Panel 1.5.2 is released?

@ahuang11
Copy link
Author

@maximlt can you provide a final review before I merge?

@maximlt
Copy link

maximlt commented Oct 24, 2024

@ahuang11 as indicated in our confluence doc, you need to ask a review from the distro team on Slack at #package-review-team. My review isn't worth much here, usually I see at least two reviews from this team.

Then, I usually let them merge the PR, but IIRC I have been told I could merge it too once approved by them. Somehow I prefer when they merge as anyway merging doesn't release the package yet, someone still needs to perform another step pushing it to the channel. I kind of assume the person merging is also going to be the person pushing the package, I may be wrong though.

@cbouss
Copy link

cbouss commented Oct 24, 2024

Upload is performed by package builder in a separate process. If you merge yourself we may miss the upload step.

recipe/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: skupr-anaconda <79282962+skupr-anaconda@users.noreply.github.com>
recipe/meta.yaml Outdated
Comment on lines 15 to 21
skip: True # [py<39 or s390x]
requirements:
host:
- python
- pip
- setuptools
- wheel
Copy link

@skupr-anaconda skupr-anaconda Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuang11 Could you revert this change? Platforms will fail on our CI (Prefect) randomly if meta.yaml doesn't have a generic requirements/host section

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a conda-build issue filed for this? Is it because of skip py on the global level without python being on the global env?

@cbouss cbouss merged commit 202de06 into master Oct 30, 2024
8 checks passed
@cbouss cbouss deleted the v1.13.0 branch October 30, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants