-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.13.0 #14
Conversation
Supersedes #13 now that I have permission to make branches directly in this repo. |
Linter check found the following problems:ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_fae_etlasm/clone` failed. (See above for error) The following problems have been found:===== ERRORS =====
|
Not sure why the tests are failing |
@ahuang11 do you think this is unblocked now Panel 1.5.2 is released? |
@maximlt can you provide a final review before I merge? |
@ahuang11 as indicated in our confluence doc, you need to ask a review from the distro team on Slack at Then, I usually let them merge the PR, but IIRC I have been told I could merge it too once approved by them. Somehow I prefer when they merge as anyway merging doesn't release the package yet, someone still needs to perform another step pushing it to the channel. I kind of assume the person merging is also going to be the person pushing the package, I may be wrong though. |
Upload is performed by package builder in a separate process. If you merge yourself we may miss the upload step. |
Co-authored-by: skupr-anaconda <79282962+skupr-anaconda@users.noreply.github.com>
recipe/meta.yaml
Outdated
skip: True # [py<39 or s390x] | ||
requirements: | ||
host: | ||
- python | ||
- pip | ||
- setuptools | ||
- wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahuang11 Could you revert this change? Platforms will fail on our CI (Prefect) randomly if meta.yaml
doesn't have a generic requirements/host
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a conda-build issue filed for this? Is it because of skip py on the global level without python being on the global env?
geoviews 1.13.0
Destination channel: defaults
Links
Upstream repository
Upstream changelog/diff
Explanation of changes:
https://github.com/conda-forge/geoviews-feedstock/pull/41/files