(Chore) Remove canvas to fix Netlify build #1572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
reviewed
Apr 29, 2021
| - name: Install required libraries | ||
| run: sudo apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev | ||
| run: sudo apt-get install libgif-dev |
There was a problem hiding this comment.
What is libgif-dev needed for?
|
Closed because the PR caused unit tests to fail on CI - checking it out |
MauritsR
force-pushed
the
chore/remove-canvas
branch
from
bd8d09c
to
9b374b1
Compare
|
@MauritsR FYI the author of |
👍 Was already looking at it - happy to see the binaries added so fast. Netlify now builds correctly (would have been quite a hassle to install the binaries there). Closing this PR but will open a new one to remove redundant binaries install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes canvas from package.json so that it's dependencies don't have to be installed (Dockerfile / ci)
This should also fix the Netlify build, which was not updated to perform the above installations.