Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D dim momenta and states #19

Merged
merged 30 commits into from
Feb 11, 2025
Merged

D dim momenta and states #19

merged 30 commits into from
Feb 11, 2025

Conversation

GDeLaurentis
Copy link
Contributor

@GDeLaurentis GDeLaurentis commented Jan 23, 2025

Merging branch with definition of D dimensional states and D dimensional momenta generator

Copy link
Contributor

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to add also a test "run amplitude in D eq 6" or something a bit more fancy than 4?

Perhaps even with fixed numbers like a regression test, to make sure that if we go around changing stuff it works also when doing things that are not 4D.

@GDeLaurentis
Copy link
Contributor Author

Added a test to match Caravel in D=6 with genuine D=6 momenta. Could add a couple more internal consistency tests in D>4.

@scarlehoff
Copy link
Contributor

scarlehoff commented Feb 6, 2025

I've tried solving the conflicts, for the tests I've had to add singular manually, but it should not be required for the rest of the code right? Or is it a general dependency now? It was not clear to me.

@GDeLaurentis
Copy link
Contributor Author

Singular is required to generate D dimensional phase space points, functions dDimPhaseSpaceQRing and random_phase_space_point. If the phase space point is provided then it should not be needed. Only if those functions are called a call to Singular is made.

Perhaps I should check that syngular can be imported even if Singular is not installed.

@scarlehoff
Copy link
Contributor

Could you also add a couple of lines to the example notebook RE what it is doing? I think it is a nice addition because it shows an example of use but it is hard to follow if you don't know what is happening.

In the meantime I'll add a few wrappers around things like another_j so that it has a more friendly name.

@scarlehoff scarlehoff merged commit 79336ce into main Feb 11, 2025
2 checks passed
@scarlehoff scarlehoff deleted the d_dim_momenta_and_states branch February 11, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants