-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D dim momenta and states #19
Conversation
…ated example to compute any D dim tree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make sense to add also a test "run amplitude in D eq 6" or something a bit more fancy than 4?
Perhaps even with fixed numbers like a regression test, to make sure that if we go around changing stuff it works also when doing things that are not 4D.
Added a test to match Caravel in D=6 with genuine D=6 momenta. Could add a couple more internal consistency tests in D>4. |
I've tried solving the conflicts, for the tests I've had to add |
Singular is required to generate D dimensional phase space points, functions Perhaps I should check that syngular can be imported even if Singular is not installed. |
Could you also add a couple of lines to the example notebook RE what it is doing? I think it is a nice addition because it shows an example of use but it is hard to follow if you don't know what is happening. In the meantime I'll add a few wrappers around things like |
…es into d_dim_momenta_and_states
…into changes_before_public
Add user facing interface
Merging branch with definition of D dimensional states and D dimensional momenta generator