Fix static analysis issues #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahasAmp
changed the title
ahasAmp
requested review from
convenient,
cvdberg1,
MattRedgate and
alinaampersand
convenient
reviewed
Dec 8, 2023
| @@ -108,10 +108,10 @@ private function getAddressFromOrder(OrderInterface $order): ?AddressInterface | |||
|
|
|||
| return $this->addressInterfaceFactory->create([ | |||
| 'country' => $shippingAddress->getCountryId(), | |||
| 'postcode' => $shippingAddress->getPostcode() ?? '', | |||
| 'postcode' => $shippingAddress->getPostcode() ? $shippingAddress->getPostcode() : '', | |||
There was a problem hiding this comment.
https://www.php.net/manual/en/migration70.new-features.php
Not sure whats complaining here, this seems like an old way of doing it? or am i completely misinterpreting this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor/ampersand/magento2-disable-stock-reservation/src/Model/GetInventoryRequestFromOrder.php
111 Expression on left side of ?? is not nullable.
114 Expression on left side of ?? is not nullable.
36 Property Ampersand\DisableStockReservation\Plugin\Model\OrderRepositoryPlugin::$sourceSelectionResultInterfaceFactory is never read, only written.
65 Property
Ampersand\DisableStockReservation\Plugin\SourceDeductionProcessor::$orderExtensionFactoryis never read, only written.