Add 'meaningful' checks to XML files #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nding-of-file-changes' into poc-meaningful-semantic-understanding-of-file-changes-xml
convenient
force-pushed
the
poc-meaningful-semantic-understanding-of-file-changes-xml
branch
from
fa9d6d8 to
85ee360
Compare
4 tasks
convenient
merged commit a894a50
into
poc-meaningful-semantic-understanding-of-file-changes
2 checks passed
convenient
deleted the
poc-meaningful-semantic-understanding-of-file-changes-xml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #110
Ignore Override Warning
In this case
vendor/magento/module-catalog/view/frontend/layout/catalog_category_view_type_default.xmlwas updated with some whitespace/comment/etc so its not really changed, so don't bother reporting on it. TheIGNRentries are suppressed without--show-ignoreRedundant override
In this case
vendor/magento/theme-frontend-blank/etc/view.xmlhas been updated and is now equivalent (excluding some whitespace/comments) tovendor/ampersand/upgrade-patch-helper-test-hyva-fallback-theme/theme/etc/view.xml