Implement 'meaningful' checks to .js
#112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #110
Ignore Override Warning
In this case
vendor/ampersand/upgrade-patch-helper-test-module/src/theme/Magento_Checkout/web/js/ignore.js
was updated with some whitespace/comment/etc so its not really changed, so don't bother reporting on it. TheIGNR
entries are suppressed without--show-ignore
Redundant override
In this case
vendor/ampersand/upgrade-patch-helper-test-module/src/theme/Magento_Checkout/web/js/redundant.js
has been updated and is now equivalent (excluding some whitespace/comments) toapp/design/frontend/Ampersand/theme/Magento_Checkout/web/js/redundant.js
The
app/design
override is now redundant and not necessaryAdditional test case changes
The additional test cases needed updated as this file is being ignored, due to the fact its only a comment / whitespace from magento/magento2@1697149
Previously a human would have had to look at the change and work it out themselves, now its not reported.
And these files are being flagged as redundant, because
vendor/paypal/module-braintree-core/view/base/web/js/form-builder.js
has been edited/changed and is now the same asvendor/paypal/module-braintree-core/view/frontend/web/js/form-builder.js