Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'meaningful' checks to .js #112

Conversation

convenient
Copy link
Contributor

@convenient convenient commented Nov 1, 2023

Part of #110

Ignore Override Warning

| IGNR  | Override (phtml/js/html) | vendor/ampersand/upgrade-patch-helper-test-module/src/theme/Magento_Checkout/web/js/ignore.js                                      | app/design/frontend/Ampersand/theme/Magento_Checkout/web/js/ignore.js                                                              |

In this case vendor/ampersand/upgrade-patch-helper-test-module/src/theme/Magento_Checkout/web/js/ignore.js was updated with some whitespace/comment/etc so its not really changed, so don't bother reporting on it. The IGNR entries are suppressed without --show-ignore

Redundant override

| WARN  | Redundant Override       | vendor/ampersand/upgrade-patch-helper-test-module/src/theme/Magento_Checkout/web/js/redundant.js                                   | app/design/frontend/Ampersand/theme/Magento_Checkout/web/js/redundant.js                                                           |

In this case vendor/ampersand/upgrade-patch-helper-test-module/src/theme/Magento_Checkout/web/js/redundant.js has been updated and is now equivalent (excluding some whitespace/comments) to app/design/frontend/Ampersand/theme/Magento_Checkout/web/js/redundant.js

The app/design override is now redundant and not necessary

Additional test case changes

The additional test cases needed updated as this file is being ignored, due to the fact its only a comment / whitespace from magento/magento2@1697149

Previously a human would have had to look at the change and work it out themselves, now its not reported.

diff -ur -N vendor_orig/magento/module-vault/view/frontend/web/js/view/payment/vault.js vendor/magento/module-vault/view/frontend/web/js/view/payment/vault.js
--- vendor_orig/magento/module-vault/view/frontend/web/js/view/payment/vault.js	2020-04-13 17:35:44.000000000 +0000
+++ vendor/magento/module-vault/view/frontend/web/js/view/payment/vault.js	2023-06-07 19:25:10.000000000 +0000
@@ -3,7 +3,7 @@
  * See COPYING.txt for license details.
  */
 /*browser:true*/
-/*global define*/
+
 /* @api */
 define([
     'underscore',

And these files are being flagged as redundant, because vendor/paypal/module-braintree-core/view/base/web/js/form-builder.js has been edited/changed and is now the same as vendor/paypal/module-braintree-core/view/frontend/web/js/form-builder.js

e676f80e153b2a8e55da763f237cabf4  vendor/paypal/module-braintree-core/view/base/web/js/form-builder.js
e676f80e153b2a8e55da763f237cabf4  vendor/paypal/module-braintree-core/view/frontend/web/js/form-builder.js

@convenient convenient marked this pull request as ready for review November 2, 2023 08:58
@convenient convenient merged commit 7c6bb63 into poc-meaningful-semantic-understanding-of-file-changes Nov 2, 2023
2 checks passed
@convenient convenient deleted the poc-meaningful-semantic-understanding-of-file-changes-js branch November 2, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant