Implement 'meaningful' checks to email html #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
convenient
merged commit fe63dc1
into
poc-meaningful-semantic-understanding-of-file-changes
2 checks passed
convenient
deleted the
poc-meaningful-semantic-understanding-of-file-changes-html-email
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #110
Implement "meaningful" checks for
.htmlemail templates.In this case
vendor/ampersand/upgrade-patch-helper-test-module/src/module/view/frontend/email/ignore.htmlhad some changes that were a comment or whitespace, so not worth actually reporting. It's flagged as ignored and hidden by default.In this case
vendor/ampersand/upgrade-patch-helper-test-module/src/module/view/frontend/email/redundant.htmlhad some changes made to it, and the contents now equate toapp/design/frontend/Ampersand/theme/Ampersand_TestVendor/email/redundant.htmlso the localapp/designcopy is redundant and can be removed.