Ignore hyva-themes/magento2-reset-theme files
#109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convenient
changed the title
hyva-themes/magento2-reset-theme files
|
Spoke with Willem from Hyva, he reckons this is grand 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After speaking with @peterjaap it seems that any changes made within
hyva-themes/magento2-reset-themecan be considered safe, and not something that you need to check during an upgrade.For example if there's a change within reset theme like to
vendor/hyva-themes/magento2-reset-theme/Magento_Contact/layout/override/base/contact_index_index.xmlit is apparently not really necessary to report that you need to check your customisations withinapp/design/frontend/SomethingSuper/default/Magento_Contact/layout/contact_index_index.xmlI am just checking with a few more hyva users if this understanding is the desired functionality before merging.
Checklist