Improve edge case handling of db_schema.xml #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When only whitespace or comments were added to a db_schema.xml file, and you ran with `-vvv and --php-strict-errors` you would get an exception with ``` could not work out db schema changes for this diff ``` This is not really necessary, and gets in the way of debugging actual errors when using `-vvv --php-strict-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only whitespace or comments (like licence info etc) were added to a
db_schema.xmlfile, and you ran with-vvvand--php-strict-errorsyou would get an exception withThis is not really necessary, and gets in the way of debugging actual errors when using
-vvv --php-strict-errorsChecklist