Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ClassPluginPhp.php (fix #103) #104

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Update ClassPluginPhp.php (fix #103) #104

merged 2 commits into from
Jul 11, 2023

Conversation

convenient
Copy link
Contributor

@convenient convenient commented Jul 10, 2023

See #103 (comment)

Handle cases where the plugin definition has not been fully formed.

Without this change you get a failure like

Test 'FunctionalTests::testMagentoTwoFourFivePointOneNoDb' started
In ClassPluginPhp.php line 78:
                                  
  Undefined array key "instance"  
                                  
analyse [-a|--auto-theme-update [AUTO-THEME-UPDATE]] [--sort-by-type] [--phpstorm-threeway-diff-commands] [--vendor-namespaces [VENDOR-NAMESPACES]] [--filter FILTER] [--pad-table-columns PAD-TABLE-COLUMNS] [--php-strict-errors] [--show-info] [--] <project>
Test 'FunctionalTests::testMagentoTwoFourFivePointOneNoDb' ended

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • Tests have been ran / updated

@convenient convenient merged commit 63698a0 into master Jul 11, 2023
@convenient convenient deleted the fix-issue-103 branch July 11, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning 'Undefined array key "instance"' on plugins that don't define a classname
1 participant