Robustify T2DocView config resolution in T3 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows e.g. dynamically registered configs to be resolved in T2DocView even if the AlertConsumer task is skipped.
When a unit raises an exception, the generator returned by ThreadedViewGenerator.__init__ would exit instantly, causing the wrapped JoinableQueue to...never join. Wrap in a try/finally block to ensure that the queue is always consumed.
jvansanten
force-pushed
the
load-old-confids
branch
from
743958a to
98cb869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs that caused
T2DocView.configto always beNoneat T3 if any of the following were true:T3SimpleStagerwith a single unit. For multiple units,T3ThreadedStagerresolved the configs correctly.