Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cascading] from release/9.0.0-rc to main #552

Merged
merged 12 commits into from
Jul 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,11 @@ export class CascadingProbot extends Cascading {
/** @inheritdoc */
protected async getBranches() {
this.logger.debug('List remote branches');
const res = await this.options.octokit.repos.listBranches(this.options.repo);
const res = await this.options.octokit.repos.listBranches({
...this.options.repo,
// eslint-disable-next-line @typescript-eslint/naming-convention, camelcase
per_page: 100
});
return res.data.map(({name}) => name);
}

Expand Down
3 changes: 2 additions & 1 deletion apps/github-cascading-app/src/cascading/cascading.ts
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ export abstract class Cascading {

const currentBranch = cascadingBranches[branchIndex];
const targetBranch = cascadingBranches[branchIndex + 1];
const cascadingBranch = this.determineCascadingBranchName(currentBranch.semver?.format() || currentBranch.branch, targetBranch.semver?.format() || targetBranch.branch);
let cascadingBranch = this.determineCascadingBranchName(currentBranch.semver?.format() || currentBranch.branch, targetBranch.semver?.format() || targetBranch.branch);
const isAhead = await this.isBranchAhead(currentBranch.branch, targetBranch.branch);

if (!isAhead) {
Expand Down Expand Up @@ -373,6 +373,7 @@ export abstract class Cascading {
}
const conflictCascadingBranch = this.determineCascadingBranchName(currentBranch.semver?.format() || currentBranch.branch, targetBranch.semver?.format() || targetBranch.branch, true);
await this.createBranch(conflictCascadingBranch, currentBranch.branch);
cascadingBranch = conflictCascadingBranch;
}
}
await this.createPullRequestWithMessage(cascadingBranch, currentBranch.branch, targetBranch.branch, config);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
"properties": {
"name": {
"type": "string",
"description": "Project name (NPM package scope)",
"x-prompt": "Project name (NPM package scope)?"
"description": "Project name (NPM package scope, package.json name will be @{projectName}/{packageName})",
"x-prompt": "Project name (NPM package scope, package.json name will be @{projectName}/{packageName})?"
},
"package": {
"type": "string",
"description": "Package name",
"x-prompt": "Package name?",
"description": "Package name (package.json name will be @{projectName}/{packageName})",
"x-prompt": "Package name (package.json name will be @{projectName}/{packageName})?",
"default": "sdk"
},
"description": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import type { JsonObject } from '@angular-devkit/core';

export interface NgGenerateTypescriptSDKShellSchematicsSchema extends JsonObject {
/** Project name (NPM package scope) */
/** Project name (NPM package scope, package.json name will be @{projectName}/{packageName}) */
name: string;

/** Package name */
/** Package name (package.json name will be @{projectName}/{packageName}) */
package: string;

/** Project description */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export class ComponentConfigExtractor {
} else if (configurationWrapper) {
const type = this.checker.getTypeFromTypeNode(typeNode);
const baseTypes = type.getBaseTypes();
const symbolName = this.getSymbolName(type.symbol);
const symbolName = this.getSymbolName(type.symbol || type.aliasSymbol);
const alreadyExtracted = !!configurationWrapper.nestedConfiguration.find((c) => c.name === symbolName);
const extendsNested = !!baseTypes?.some((baseType) => this.getSymbolName(baseType.symbol).match(/^NestedConfiguration$/));
if (extendsNested && !alreadyExtracted) {
Expand Down
1 change: 1 addition & 0 deletions packages/@o3r/dynamic-content/src/stores/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export * from './asset-path-override/asset-path-override.actions';
export * from './asset-path-override/asset-path-override.module';
export * from './asset-path-override/asset-path-override.reducer';
export * from './asset-path-override/asset-path-override.selectors';
export * from './asset-path-override/asset-path-override.state';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class MatAutocomplete extends O3rElement implements MatAutocompleteProfil
await this.setValue(value);
await this.click();
const element = this.sourceElement.page;
const matOptions = element.locator('.mat-option');
const matOptions = element.locator('.mat-option, mat-option');
await matOptions.first().waitFor({state: 'attached', timeout});
const matOptionsCount = await matOptions.count();
const options: (string | undefined)[] = [];
Expand All @@ -32,6 +32,6 @@ export class MatAutocomplete extends O3rElement implements MatAutocompleteProfil
return this.sourceElement.element.press('Tab');
}

return Promise.reject('Element with selector .mat-option not found.');
return Promise.reject('Element with selector .mat-option, mat-option not found.');
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class MatAutocomplete extends O3rElement implements MatAutocompleteProfil
public async selectByValue(value: string, _timeout?: number) {
await this.setValue(value);
await this.click();
const matOption = element(By.css('.mat-option'));
const matOption = element(By.css('.mat-option, mat-option'));
return new O3rElement(matOption).click();
}
}