Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish-pr on external workflow #545

Merged
merged 1 commit into from
Jul 26, 2023
Merged

ci: publish-pr on external workflow #545

merged 1 commit into from
Jul 26, 2023

Conversation

fpaul-1A
Copy link
Contributor

@fpaul-1A fpaul-1A commented Jul 18, 2023

Proposed change

Currently, for external contributions, the workflow is not able to access secrets variables, so the job publish-pr is failing

One solution is to create another workflow triggered by workflow_run:completed that handle the publication

Related issues

  • 🐛 Fixes #(issue)
  • 🚀 Feature #(issue)

@fpaul-1A fpaul-1A force-pushed the ci/external-publish-pr branch 2 times, most recently from 11c11bf to 17971a3 Compare July 18, 2023 15:44
@nx-cloud
Copy link

nx-cloud bot commented Jul 18, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2c9af14. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@fpaul-1A fpaul-1A force-pushed the ci/external-publish-pr branch 2 times, most recently from 7cc63d0 to d44e74f Compare July 19, 2023 15:42
@fpaul-1A fpaul-1A changed the title [WIP] ci: publish-pr on external workflow ci: publish-pr on external workflow Jul 19, 2023
@fpaul-1A fpaul-1A marked this pull request as ready for review July 19, 2023 15:42
@fpaul-1A fpaul-1A requested a review from a team as a code owner July 19, 2023 15:42
@fpaul-1A fpaul-1A force-pushed the ci/external-publish-pr branch 2 times, most recently from 208b2c1 to 6dc562c Compare July 21, 2023 07:15
@kpanot kpanot added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 56a1613 Jul 26, 2023
14 checks passed
@kpanot kpanot deleted the ci/external-publish-pr branch July 26, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants