test: lighthouse checks on e2e #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit aebb78c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
fpaul-1A
force-pushed
the
test/e2e-lighthouse
branch
2 times, most recently
from
8ee42f1
to
0545a28
Compare
fpaul-1A
changed the title
fpaul-1A
force-pushed
the
test/e2e-lighthouse
branch
3 times, most recently
from
ae6e026
to
8e5bdd2
Compare
fpaul-1A
force-pushed
the
test/e2e-lighthouse
branch
from
8e5bdd2
to
aebb78c
Compare
| @@ -230,12 +230,14 @@ | |||
| "js-yaml": "^4.1.0", | |||
| "jsonc-eslint-parser": "~2.4.0", | |||
| "jsonpath-plus": "^8.0.0", | |||
| "lighthouse": "9.6.8", | |||
There was a problem hiding this comment.
why frozen versions for the new deps?
There was a problem hiding this comment.
newer versions don't seem to support CommonJS abhinaba-ghosh/playwright-lighthouse#51
vscaiceanu-1a
approved these changes
Mar 5, 2024
matthieu-crouzet
approved these changes
Mar 6, 2024
kpanot
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The goal is to prevent regressions regarding accessibility on the showcase app
Related issues