fix(metric): avoid awaiting the metric report call #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
kpanot
force-pushed
the
bugfix/schematic-metrics-reporting
branch
from
52c6ca6
to
91fb523
Compare
kpanot
force-pushed
the
bugfix/schematic-metrics-reporting
branch
from
91fb523
to
badf9ff
Compare
fpaul-1A
reviewed
Jan 29, 2024
| }, | ||
| error | ||
| }; | ||
| context.logger.debug(JSON.stringify(data, null, 2)); |
There was a problem hiding this comment.
we should probably remove this
There was a problem hiding this comment.
It was more for us when we run the command with --verbose
fpaul-1A
reviewed
Jan 29, 2024
| duration, | ||
| error | ||
| }; | ||
| context.logger.debug(JSON.stringify(data, null, 2)); |
There was a problem hiding this comment.
we should probably remove this (or add a message)
fpaul-1A
approved these changes
Jan 29, 2024
matthieu-crouzet
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Avoid awaiting the metric report call
Related issues