feat: improve ama-sdk plugins logging #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
packages/@ama-sdk/core/src/plugins/session-id/session-id.request.ts
Outdated
Show resolved
Hide resolved
packages/@ama-sdk/core/src/plugins/pii-tokenizer/pii-tokenizer.request.ts
Show resolved
Hide resolved
...s/@ama-sdk/core/src/plugins/bot-protection-fingerprint/bot-protection-fingerprint.request.ts
Show resolved
Hide resolved
kpanot
reviewed
Jan 4, 2024
| @@ -63,7 +63,7 @@ export class ApiAngularClient implements ApiClient { | |||
| let opts = options; | |||
| if (this.options.requestPlugins) { | |||
| for (const plugin of this.options.requestPlugins) { | |||
| opts = await plugin.load().transform(opts); | |||
| opts = await plugin.load({logger: this.options.logger}).transform(opts); | |||
There was a problem hiding this comment.
could be simplified to
Suggested change
| opts = await plugin.load({logger: this.options.logger}).transform(opts); | |
| opts = await plugin.load(this.options).transform(opts); |
...s/@ama-sdk/core/src/plugins/bot-protection-fingerprint/bot-protection-fingerprint.request.ts
Outdated
Show resolved
Hide resolved
packages/@ama-sdk/core/src/plugins/session-id/session-id.request.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
reviewed
Jan 4, 2024
packages/@ama-sdk/core/src/plugins/session-id/session-id.request.ts
Outdated
Show resolved
Hide resolved
sdo-1A
force-pushed
the
feat/ama-sdk-plugins-logging
branch
from
780e12c
to
5118e9f
Compare
kpanot
reviewed
Jan 4, 2024
packages/@ama-sdk/core/src/plugins/session-id/session-id.request.ts
Outdated
Show resolved
Hide resolved
sdo-1A
force-pushed
the
feat/ama-sdk-plugins-logging
branch
from
5118e9f
to
636b177
Compare
kpanot
reviewed
Jan 5, 2024
sdo-1A
force-pushed
the
feat/ama-sdk-plugins-logging
branch
from
636b177
to
537c8e3
Compare
kpanot
reviewed
Jan 5, 2024
packages/@ama-sdk/core/src/plugins/session-id/session-id.request.ts
Outdated
Show resolved
Hide resolved
packages/@ama-sdk/core/src/plugins/session-id/session-id.request.ts
Outdated
Show resolved
Hide resolved
sdo-1A
force-pushed
the
feat/ama-sdk-plugins-logging
branch
from
537c8e3
to
ad25371
Compare
kpanot
reviewed
Jan 5, 2024
packages/@ama-sdk/core/src/plugins/session-id/session-id.request.ts
Outdated
Show resolved
Hide resolved
sdo-1A
force-pushed
the
feat/ama-sdk-plugins-logging
branch
from
ad25371
to
252c8ee
Compare
matthieu-crouzet
previously approved these changes
Jan 9, 2024
fpaul-1A
reviewed
Jan 9, 2024
packages/@ama-sdk/core/package.json
Outdated
| @@ -76,6 +77,9 @@ | |||
| "@angular/common": { | |||
| "optional": true | |||
| }, | |||
| "@o3r/core": { | |||
| "optional": true | |||
There was a problem hiding this comment.
is it really optional ?
regardless, @o3r/core should also be added in the devDependencies generated by the @ama-sdk/schematics:typescript-shell https://github.com/AmadeusITGroup/otter/blob/release/10.0.0-next/packages/%40ama-sdk/schematics/schematics/typescript/shell/templates/base/package.json.template#L79
There was a problem hiding this comment.
I think it is optional since it is only used to import types (Logger from @o3r/core)
sdo-1A
force-pushed
the
feat/ama-sdk-plugins-logging
branch
from
252c8ee
to
e93b3bf
Compare
sdo-1A
force-pushed
the
feat/ama-sdk-plugins-logging
branch
4 times, most recently
from
2ebc079
to
ecec776
Compare
sdo-1A
force-pushed
the
feat/ama-sdk-plugins-logging
branch
from
ecec776
to
686ac66
Compare
kpanot
approved these changes
Jan 11, 2024
| * @param message Message to log | ||
| * @param optionalParams Optional parameters to log | ||
| */ | ||
| error(message?: any, ...optionalParams: any[]): void; |
There was a problem hiding this comment.
Maybe it could be valuable to have the this: Logger as first param to avoid le context loosing usage
cpaulve-1A
approved these changes
Jan 12, 2024
sdo-1A
force-pushed
the
feat/ama-sdk-plugins-logging
branch
from
686ac66
to
dfdcdb2
Compare
vscaiceanu-1a
added a commit
that referenced
this pull request
May 2, 2024
## Proposed change Cherry-pick of #1184 on 9.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Possibility to connect a third-party logger in ama-sdk, fallback to console logger if undefined.
Related issues